feat(eslint-plugin): add rule prefer-output-emitter-ref #2324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View your CI Pipeline Execution ↗ for commit fd27147.
☁️ Nx Cloud last updated this comment at |
JamesHenry
reviewed
Mar 22, 2025
|
🤦♂️ I forgot that |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2324 +/- ##
==========================================
+ Coverage 92.53% 92.56% +0.02%
==========================================
Files 184 186 +2
Lines 3726 3737 +11
Branches 836 836
==========================================
+ Hits 3448 3459 +11
Misses 215 215
Partials 63 63
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
JamesHenry
requested changes
Mar 22, 2025
JamesHenry
approved these changes
Apr 8, 2025
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2258
This adds a new rule to the
eslint-plugincalledprefer-output-emitter-ref. There are two problems that this will detectIt will report a problem when an
@Outputdecorator is used. This is not fixable since doing so would be quite complicated. There's also an Angular migration (feat(core): initial version of the output migration angular/angular#57604), so it's simpler to just use the migration.It will report a problem if an
OutputEmitterRefproperty in a component or decorator is not read-only. This is fixable.