Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(eslint-plugin-template): [prefer-at-empty] remove closing brace from @if when no longer needed #2450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 25, 2025
Merged

fix(eslint-plugin-template): [prefer-at-empty] remove closing brace from @if when no longer needed #2450

merged 1 commit into from
May 25, 2025

Conversation

reduckted
Copy link
Contributor

@reduckted reduckted changed the base branch from main to next-major-release/v20 May 25, 2025 01:55
@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented May 25, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 4e86fa7.

Command Status Duration Result
nx run-many -t e2e-suite --parallel 1 ✅ Succeeded 14s View ↗
nx run-many -t test --codeCoverage ✅ Succeeded 46s View ↗
nx run-many -t build,typecheck,check-rule-docs,... ✅ Succeeded 2m 9s View ↗
nx-cloud record -- pnpm nx sync:check ✅ Succeeded 2s View ↗
nx-cloud record -- pnpm format-check ✅ Succeeded 6s View ↗
nx run-many -t test ✅ Succeeded 26s View ↗
nx run-many -t build ✅ Succeeded 15s View ↗

☁️ Nx Cloud last updated this comment at 2025-05-25 09:19:32 UTC

@reduckted reduckted mentioned this pull request May 25, 2025
Merged
10 tasks
@codecov Codecov
Copy link

codecov bot commented May 25, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.85%. Comparing base (2ef4cb3) to head (4e86fa7).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2450   +/-   ##
=======================================
  Coverage   92.84%   92.85%           
=======================================
  Files         195      195           
  Lines        4083     4085    +2     
  Branches      951      952    +1     
=======================================
+ Hits         3791     3793    +2     
  Misses        225      225           
  Partials       67       67
Flag Coverage Δ
unittest 92.85% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...slint-plugin-template/src/rules/prefer-at-empty.ts 94.66% <100.00%> (+0.07%) ⬆️
...ugin-template/tests/rules/prefer-at-empty/cases.ts 100.00% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

JamesHenry
JamesHenry requested changes May 25, 2025
View reviewed changes
Copy link
Member

@JamesHenry JamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need this into main please it’s a current issue, I’ll port it into v20 after that

@reduckted reduckted force-pushed the bugfix/prefer-at-empty-parse-error branch from 3f59083 to 4e86fa7 Compare May 25, 2025 09:13
@reduckted reduckted changed the base branch from next-major-release/v20 to main May 25, 2025 09:13
@JamesHenry
Copy link
Member

@reduckted Thanks but this should still have been modifying the existing test that has a parse error in it? Not just adding something net new?

@reduckted
Copy link
Contributor Author

@reduckted Thanks but this should still have been modifying the existing test that has a parse error in it? Not just adding something net new?

👍 Done!

@JamesHenry
Copy link
Member

@reduckted I wonder if you replied by email or something because that reply was too fast, and inaccurate 😄

@reduckted
Copy link
Contributor Author

@reduckted Thanks but this should still have been modifying the existing test that has a parse error in it? Not just adding something net new?

I think the diff is just a bit confusing. The existing test called replaces '@empty' block when '@for' block is inside '@else' block has removed a closing brace from the end of the annotatedOutput, and I've added another test because I noticed there wasn't a test case for having an @for without an existing @empty block in the @else. In the diff, the closing brace from the previous test is showing as being part of that new test, which is correct.

@JamesHenry
Copy link
Member

Ah you're right, the new test made the diff confusing. Thanks!

@JamesHenry JamesHenry merged commit fb917fc into angular-eslint:main May 25, 2025
11 of 14 checks passed
@reduckted reduckted deleted the bugfix/prefer-at-empty-parse-error branch May 25, 2025 10:34
igord pushed a commit to tcorral/angular-eslint that referenced this pull request Jun 1, 2025
@reduckted @igord
fix(eslint-plugin-template): [prefer-at-empty] remove closing brace f…
1913d46 
…rom @if when no longer needed (angular-eslint#2450)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamesHenry JamesHenry JamesHenry requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reduckted @JamesHenry