fix(eslint-plugin): [sort-keys-in-type-decorator] preserve unconfigured properties during autofix #2456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed properties during autofix The autofix was removing properties that weren't in the expected order configuration. This fix ensures all properties are preserved, with configured properties sorted according to the expected order and unconfigured properties appended at the end. Fixes #2455 Co-authored-by: JamesHenry <[email protected]>
|
View your CI Pipeline Execution ↗ for commit 537935c.
☁️ Nx Cloud last updated this comment at |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2456 +/- ##
==========================================
+ Coverage 92.81% 92.84% +0.02%
==========================================
Files 195 195
Lines 4090 4093 +3
Branches 954 954
==========================================
+ Hits 3796 3800 +4
Misses 226 226
+ Partials 68 67 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
Thx @JamesHenry , thought I covered that initially.. 🙈 |
This was referenced May 26, 2025
igord
pushed a commit
to tcorral/angular-eslint
that referenced
this pull request
Jun 1, 2025
…ed properties during autofix (angular-eslint#2456)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2455
The autofix was removing properties that weren't in the expected order configuration. This fix ensures all properties are preserved, with configured properties sorted according to the expected order and unconfigured properties appended at the end.
Generated with Claude Code