fix: respect existing eslint.config.ts, eslint.config.cts, eslint.config.mts files #2458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View your CI Pipeline Execution ↗ for commit bf3c25e.
☁️ Nx Cloud last updated this comment at |
b7d82af to
4492b15
Compare
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (73.80%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #2458 +/- ##
==========================================
+ Coverage 92.84% 92.98% +0.14%
==========================================
Files 195 195
Lines 4093 4105 +12
Branches 954 959 +5
==========================================
+ Hits 3800 3817 +17
+ Misses 226 221 -5
Partials 67 67
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
4492b15 to
3ee1dc3
Compare
igord
pushed a commit
to tcorral/angular-eslint
that referenced
this pull request
Jun 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This PR does not yet handle generating such files, but they will be respected if they already exist, that's why I'm marking this as a fix.
Just like with ESLint directly, it is up to you to ensure that an appropriate version of
jitiis installed to make it work (ESLint will error if you don't have it, as shown in the e2e test)Fixes #2205