Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(eslint-plugin): [use-lifecycle-interface] do not report if the method uses override #2463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 26, 2025

Conversation

JamesHenry
Copy link
Member

@JamesHenry JamesHenry commented May 26, 2025

Fixes #866
Fixes #1426

Copy link

nx-cloud bot commented May 26, 2025

View your CI Pipeline Execution ↗ for commit 07c0f75.

Command Status Duration Result
nx run-many -t e2e-suite --parallel 1 ✅ Succeeded 18s View ↗
nx run-many -t test --codeCoverage ✅ Succeeded 43s View ↗
nx run-many -t build,typecheck,check-rule-docs,... ✅ Succeeded 35s View ↗
nx-cloud record -- pnpm nx sync:check ✅ Succeeded 2s View ↗
nx-cloud record -- pnpm format-check ✅ Succeeded 5s View ↗
nx run-many -t test ✅ Succeeded 34s View ↗
nx run-many -t build ✅ Succeeded 16s View ↗

☁️ Nx Cloud last updated this comment at 2025-05-26 11:27:56 UTC

Copy link

codecov bot commented May 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.84%. Comparing base (62b3a4f) to head (07c0f75).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2463   +/-   ##
=======================================
  Coverage   92.83%   92.84%           
=======================================
  Files         197      197           
  Lines        4146     4149    +3     
  Branches      971      972    +1     
=======================================
+ Hits         3849     3852    +3     
  Misses        228      228           
  Partials       69       69           
Flag Coverage Δ
unittest 92.84% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...eslint-plugin/src/rules/use-lifecycle-interface.ts 100.00% <100.00%> (ø)
...lugin/tests/rules/use-lifecycle-interface/cases.ts 100.00% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JamesHenry JamesHenry marked this pull request as ready for review May 26, 2025 11:29
@JamesHenry JamesHenry merged commit 680c033 into main May 26, 2025
9 checks passed
@JamesHenry JamesHenry deleted the use-lifecycle-interface branch May 26, 2025 11:38
igord pushed a commit to tcorral/angular-eslint that referenced this pull request Jun 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant