Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat(eslint-plugin): support multiple configs for component-selector and directive-selector #2762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 9, 2025
Merged

feat(eslint-plugin): support multiple configs for component-selector and directive-selector #2762

merged 1 commit into from
Nov 9, 2025

Conversation

@JamesHenry
Copy link
Member

@JamesHenry JamesHenry commented Nov 9, 2025

Closes #1119

@nx-cloud
Copy link

nx-cloud bot commented Nov 9, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit a9e2eae

Command Status Duration Result
nx run-many -t test ✅ Succeeded 28s View ↗
nx run-many -t build ✅ Succeeded 14s View ↗
nx run-many -t test --configuration ci ✅ Succeeded <1s View ↗
nx run-many -t build typecheck test check-rule-... ✅ Succeeded 3m 29s View ↗
nx-cloud record -- pnpm nx sync:check ✅ Succeeded 2s View ↗
nx-cloud record -- pnpm format-check ✅ Succeeded 6s View ↗

☁️ Nx Cloud last updated this comment at 2025-11-09 19:20:07 UTC

@JamesHenry JamesHenry force-pushed the multiple-configs-for-directive-and-component-selector branch from 81165cc to 453dc99 Compare November 9, 2025 19:12
@JamesHenry JamesHenry force-pushed the multiple-configs-for-directive-and-component-selector branch from 453dc99 to a9e2eae Compare November 9, 2025 19:15
@codecov
Copy link

codecov bot commented Nov 9, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 85.71429% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.64%. Comparing base (0b2f758) to head (a9e2eae).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ages/eslint-plugin/src/rules/component-selector.ts 85.71% 3 Missing ⚠️
...ages/eslint-plugin/src/rules/directive-selector.ts 85.71% 3 Missing ⚠️

❌ Your patch status has failed because the patch coverage (85.71%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2762      +/-   ##
==========================================
- Coverage   90.73%   90.64%   -0.10%     
==========================================
  Files         204      204              
  Lines        4823     4862      +39     
  Branches     1536     1550      +14     
==========================================
+ Hits         4376     4407      +31     
- Misses        441      449       +8     
  Partials        6        6
Flag Coverage Δ
unittest 90.64% <85.71%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...int-plugin/tests/rules/component-selector/cases.ts 100.00% <ø> (ø)
...int-plugin/tests/rules/directive-selector/cases.ts 100.00% <ø> (ø)
...ages/eslint-plugin/src/rules/component-selector.ts 92.06% <85.71%> (-5.62%) ⬇️
...ages/eslint-plugin/src/rules/directive-selector.ts 85.00% <85.71%> (-5.48%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JamesHenry JamesHenry marked this pull request as ready for review November 9, 2025 19:26
@JamesHenry JamesHenry merged commit 409fcf9 into main Nov 9, 2025
9 of 10 checks passed
@JamesHenry JamesHenry deleted the multiple-configs-for-directive-and-component-selector branch November 9, 2025 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[directive-selector] Allow different prefix for attribute and element usages

2 participants

@JamesHenry