Thanks to visit codestin.com
Credit goes to github.com

Skip to content

add a feature to use redirect instead of popup -add a demo for this new feature #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add a feature to use redirect instead of popup -add a demo for this new feature #2

wants to merge 1 commit into from

Conversation

clakech
Copy link

@clakech clakech commented Jun 5, 2013

warning: I reuse the same callback url because I don't have access to the
config

add a feature to use redirect instead of popup
c6eb75a 
-add a demo for this new feature

warning: I reuse the same callback url because I don't have access to the config
@ChristianWeyer
Copy link

+1 for a redirect feature!

@sheniff
Copy link
Contributor

sheniff commented Dec 5, 2013

Just one comment here: In some OAuth implementations, as in LinkedIn's (https://developer.linkedin.com/documents/authentication), state config param is used for a different purpose... Should the name of this param be changed here?

Just trying to avoid future issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@clakech @ChristianWeyer @sheniff