Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix the promise of the GoogleTokenVerifier #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 5, 2013
Merged

Fix the promise of the GoogleTokenVerifier #9

merged 1 commit into from
Sep 5, 2013

Conversation

colinbellino
Copy link
Contributor

  • Move the $deferred object to GoogleTokenVerifier and inside $injector.invoke and return directly $deferred.promise
  • Update the demo to call $rootScope.$apply inside the verifyAsync then()

Closes #1, #8

@colinbellino
fix(google): move $deferred inside of the GoogleTokenVerifier injector
7757211 
- Move the $deferred object to GoogleTokenVerifier and inside $injector.invoke and return directly $deferred.promise
- Update the demo to call $rootScope.$apply inside the verifyAsync then()

Closes #1, #8
@enginoid
Copy link
Contributor

enginoid commented Sep 5, 2013

Great commit & much needed; thanks!

@enginoid enginoid closed this Sep 5, 2013
@enginoid enginoid reopened this Sep 5, 2013
enginoid added a commit that referenced this pull request Sep 5, 2013
@enginoid
Merge pull request #9 from colin-bellino/fix-deferred
5eb25e1 
Fix the promise of the GoogleTokenVerifier
@enginoid enginoid merged commit 5eb25e1 into angular-oauth:master Sep 5, 2013
@colinbellino colinbellino mentioned this pull request Sep 5, 2013
Closed
@colinbellino colinbellino deleted the fix-deferred branch September 5, 2013 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot verify token
2 participants
@colinbellino @enginoid