-
-
Notifications
You must be signed in to change notification settings - Fork 495
First attempt to add colouring of outside areas for range sliders #553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for this! π I have added a demo to your pull request description, but you need to generate the dist files for it to work (run |
:-D I need to figure out how to use grunt :-) ... I've never used it |
You just need to run |
I had to install grunt-cli and grunt-init globally and run the global "grunt" script. |
A few first remarks:
|
Codecov Report
@@ Coverage Diff @@
## master #553 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 1 1
Lines 972 990 +18
=====================================
+ Hits 972 990 +18
Continue to review full report at Codecov.
|
Added test for new option
I need some guidance to understand what to do for code coverage. |
Ok, I think I've managed :-) Let me know if you want other things |
Great contribution! π No worries for the commits, I'll squash and merge. |
One last thing to be perfect: document the new option in the README and update the bower/npm versions to 6.4.0. Don't forget to run |
Ok, thanks. I'll do tonight (22:00 UK time) |
Changed version to 6.4.0
Trying to implement #523
I added a new option: "showOuterSelectionBars" (default: false) that when true will show two coloured area outside the selection in case of range sliders.
I also added two new .css classes for customise the colour of these two new areas.
Please review my code and let me know if meet your quality expectation ... and of course tell me if you spot any bugs on it :-)
Demo: http://jsfiddle.net/z3dLacot/