Thanks to visit codestin.com
Credit goes to github.com

Skip to content

First attempt to add colouring of outside areas for range sliders #553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Aug 12, 2017

Conversation

GMaxera
Copy link
Contributor

@GMaxera GMaxera commented Aug 8, 2017

Trying to implement #523

I added a new option: "showOuterSelectionBars" (default: false) that when true will show two coloured area outside the selection in case of range sliders.

I also added two new .css classes for customise the colour of these two new areas.

Please review my code and let me know if meet your quality expectation ... and of course tell me if you spot any bugs on it :-)

Demo: http://jsfiddle.net/z3dLacot/

@ValentinH
Copy link
Member

Thanks for this! πŸ‘ I have added a demo to your pull request description, but you need to generate the dist files for it to work (run grunt) and add the new dist files.

@GMaxera
Copy link
Contributor Author

GMaxera commented Aug 8, 2017

:-D I need to figure out how to use grunt :-) ... I've never used it

@ValentinH
Copy link
Member

You just need to run npm install to install all the dependencies and then npm run grunt.

@GMaxera
Copy link
Contributor Author

GMaxera commented Aug 8, 2017

I had to install grunt-cli and grunt-init globally and run the global "grunt" script.
"npm run grunt" was failing :-(

@ValentinH
Copy link
Member

ValentinH commented Aug 8, 2017

A few first remarks:

  • you need to handle rightToLeft: true (left outer and right outer should be inverted)
  • existing tests should be fixed
  • new tests should be added to handle this new feature

@codecov-io
Copy link

codecov-io commented Aug 8, 2017

Codecov Report

Merging #553 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #553   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines         972    990   +18     
=====================================
+ Hits          972    990   +18
Impacted Files Coverage Ξ”
src/rzslider.js 100% <100%> (ΓΈ) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update feb36f0...388ce93. Read the comment docs.

@GMaxera
Copy link
Contributor Author

GMaxera commented Aug 11, 2017

I need some guidance to understand what to do for code coverage.
It's the first time for me :-)

@GMaxera
Copy link
Contributor Author

GMaxera commented Aug 11, 2017

Ok, I think I've managed :-)
maybe with too much commits :-( sorry.

Let me know if you want other things

@ValentinH
Copy link
Member

Great contribution! πŸ‘ No worries for the commits, I'll squash and merge.

@ValentinH
Copy link
Member

One last thing to be perfect: document the new option in the README and update the bower/npm versions to 6.4.0. Don't forget to run grunt to generate the dist files after the version update. πŸ™‚

@GMaxera
Copy link
Contributor Author

GMaxera commented Aug 11, 2017

Ok, thanks. I'll do tonight (22:00 UK time)

Changed version to 6.4.0
@ValentinH ValentinH merged commit 062cf25 into angular-slider:master Aug 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants