fix(core): set check when resolve pierced props

Chau · Chau · commit 5d89ae1cb3d5 · 2025-04-06T20:48:47.000-05:00
diff --git a/apps/examples/src/app/soba/skydiving/skydiver.ts b/apps/examples/src/app/soba/skydiving/skydiver.ts
@@ -140,9 +140,8 @@ export class Skydiver {
 
 		beforeRender(({ clock }) => {
 			const skydiver = this.gltf.value()?.nodes?.skydiver_2;
-			if (skydiver?.material.uniforms?.['uTime']) {
-				skydiver.material.uniforms['uTime'].value = clock.elapsedTime;
-			}
+			const timeUniform = skydiver?.material.uniforms?.['uTime'];
+			if (timeUniform) timeUniform.value = clock.elapsedTime;
 		});
 	}
 }
diff --git a/libs/core/src/lib/utils/apply-props.ts b/libs/core/src/lib/utils/apply-props.ts
@@ -40,14 +40,20 @@ export function resolveInstanceKey(instance: any, key: string): { root: any; tar
 	if (!key.includes('.')) return { root: instance, targetKey: key, targetProp };
 
 	// Resolve pierced target
-	const chain = key.split('.');
-	targetProp = chain.reduce((acc, part) => acc[part], instance);
-	const targetKey = chain.pop()!;
-
-	// Switch root if atomic
-	if (!targetProp?.set) instance = chain.reduce((acc, part) => acc[part], instance);
-
-	return { root: instance, targetKey, targetProp };
+	targetProp = instance;
+	for (const part of key.split('.')) {
+		key = part;
+		instance = targetProp;
+		targetProp = targetProp[key];
+	}
+	// const chain = key.split('.');
+	// targetProp = chain.reduce((acc, part) => acc[part], instance);
+	// const targetKey = chain.pop()!;
+	//
+	// // Switch root if atomic
+	// if (!targetProp?.set) instance = chain.reduce((acc, part) => acc[part], instance);
+
+	return { root: instance, targetKey: key, targetProp };
 }
 
 // This function applies a set of changes to the instance

Original file line number	Diff line number	Diff line change
`@@ -140,9 +140,8 @@ export class Skydiver {`
`140`	`140`
`141`	`141`	`beforeRender(({ clock }) => {`
`142`	`142`	`const skydiver = this.gltf.value()?.nodes?.skydiver_2;`
`143`		`- if (skydiver?.material.uniforms?.['uTime']) {`
`144`		`- skydiver.material.uniforms['uTime'].value = clock.elapsedTime;`
`145`		`- }`
	`143`	`+ const timeUniform = skydiver?.material.uniforms?.['uTime'];`
	`144`	`+ if (timeUniform) timeUniform.value = clock.elapsedTime;`
`146`	`145`	`});`
`147`	`146`	`}`
`148`	`147`	`}`