refactor(core): clean up

Chau · Chau · commit e60aa62c052b · 2025-04-01T21:40:16.000-05:00
diff --git a/libs/core/src/lib/html.ts b/libs/core/src/lib/html.ts
@@ -1,19 +1,3 @@
-// import {
-// 	AbstractType,
-// 	DestroyRef,
-// 	Directive,
-// 	ElementRef,
-// 	inject,
-// 	InjectionToken,
-// 	Provider,
-// 	ProviderToken,
-// 	Type,
-// } from '@angular/core';
-// import { HTML } from './renderer-old';
-// import { DOM_PARENT } from './renderer-old/constants';
-// import { injectStore } from './store';
-// import { NgtAnyRecord } from './types';
-
 import {
 	AbstractType,
 	DestroyRef,
@@ -29,7 +13,6 @@ import { NGT_DOM_PARENT_FLAG, NGT_HTML_FLAG } from './renderer/constants';
 import { injectStore } from './store';
 import { NgtAnyRecord } from './types';
 
-//
 const NGT_HTML_DOM_ELEMENT = new InjectionToken<'gl' | HTMLElement>('NGT_HTML_DOM_ELEMENT');
 
 export function provideHTMLDomElement(): Provider;
diff --git a/libs/core/src/lib/loader-resource.ts b/libs/core/src/lib/loader-resource.ts
@@ -111,6 +111,8 @@ export function loaderResource<
 		return resource({
 			request: () => getLoaderRequestParams(input, loaderConstructorFactory, extensions),
 			loader: async ({ request }) => {
+				// TODO: use the abortSignal when THREE.Loader supports it
+
 				const loadedResults = await Promise.all(getLoaderPromises(request, onProgress));
 
 				let results: NgtLoaderResults<
@@ -142,9 +144,7 @@ export function loaderResource<
 					) as NgtLoaderResults<TUrl, NgtBranchingReturn<TReturn, NgtGLTFLike, NgtGLTFLike & NgtObjectMap>>;
 				}
 
-				if (onLoad) {
-					onLoad(results);
-				}
+				if (onLoad) onLoad(results);
 
 				return results;
 			},
diff --git a/libs/soba/abstractions/src/lib/text-3d.ts b/libs/soba/abstractions/src/lib/text-3d.ts
@@ -34,7 +34,7 @@ const defaultOptions: Partial<NgtThreeElements['ngt-mesh']> & NgtsText3DOptions
 };
 
 @Component({
-	selector: 'ngts-text-3d, ngts-text-3D',
+	selector: 'ngts-text-3d,ngts-text-3D',
 	template: `
 		<ngt-mesh #mesh [parameters]="parameters()">
 			<ngt-text-geometry #textGeometry *args="textArgs()" />
