Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Sep 8, 2020. It is now read-only.

Feat publisher #88

Closed
wants to merge 12 commits into from
Closed

Conversation

douglasduteil
Copy link
Contributor

No description provided.

@thgreasi
Copy link
Contributor

Please also create an equivalent PR for the angular1.2 branch (since I`m somewhat lost in the changeset).

@douglasduteil
Copy link
Contributor Author

You can't rebase ?

@douglasduteil
Copy link
Contributor Author

Wait I'm doing it

@douglasduteil
Copy link
Contributor Author

All done.
@thgreasi I directly use your changes for the conflicts with a git checkout --theirs ...
So it erased the jshint corrections I made https://travis-ci.org/angular-ui/ui-sortable/builds/16086719

@douglasduteil
Copy link
Contributor Author

3ff67a5 JShint pass for the sources
I'm jshint-ing the tests now https://travis-ci.org/angular-ui/ui-sortable/builds/16087151

@douglasduteil
Copy link
Contributor Author

fe67bb0 JShint pass for everything
Sorry for the trouble...

@douglasduteil
Copy link
Contributor Author

Hi @thgreasi

Guess you noticed but this merging activate the 'auto publishing mode' (using the angular ui publisher)
New commits on the master branch with a successful test will be automatically published using it's current tag version. It the tag don't already exist it'll be created on the bower branch with your dist files only. Still you can manually create all the tags you want for your sources.
I'm pushing forward as best practice to always create a source tag like srcX.X.X (ex: src0.2.1 for the build version v0.2.1) for your sources.

All this is for accessing to the component though bower with :

# the latest build
bower install angular-ui-sortable\#bower

# the build v0.2.1
bower install angular-ui-sortable\#v0.2.1

# the master source v0.2.1
bower install angular-ui-sortable\#src0.2.1

# etc...

I look forward to have your feedback on this.
Tell me when you are ready to launch merge and publish the angular 1.2 version.
It will be a good occasion to merge the changelog generator task #72 (we may have to reword some important commits)

You're doing a great work maintaining all this I hope my changes don't hurt :)

@thgreasi
Copy link
Contributor

Oh soz @douglasduteil! I will take a look at the tagging after angular1.2 branch is pushed forward to the changes of the master branch.

I`m currently doing a manual 3-way merge of the new master branch and the angular1.2.
(actually 4-way of you count the rebased brancha as well...)

Thanks for all, hope I don't break anything.

PS: Shall I re-enable the indentation check to 2 spaces, as it was before (in the angular1.2 branch)?

@douglasduteil
Copy link
Contributor Author

Shall I re-enable the indentation check to 2 spaces, as it was before (in the angular1.2 branch)?

@thgreasi Yep sure ! I like 2 spaces indentations 👍

@douglasduteil
Copy link
Contributor Author

@thgreasi What do you think about the current statue of this repo ? Have you consider making a native/pure angular version of this sortable logic ? or do you think it's a bad idea, a waist of time or an irrelevant fork ?

@thgreasi
Copy link
Contributor

@douglasduteil Just merged you changes to angular1.2 branch. (feel free to drop the rebased branch.)

I think angular1.2 branch is quite mature (especially after #82). But still, not yet investigated #75...

Since the angularJS 1.2 changes had a major impact to the codebase of uiSortable I have considered a rewrite. Thats because we are fighting with the ngRepeat comments and the way jquery.ui.sortable manipulated the DOM elements. Though, since I think that the feature parity that we are offering is important, it might should be better to just integrate jquery.ui.sortable functionality into the directive and just have jquery.ui.widget & jquery.ui.draggable as dependencies.

@douglasduteil
Copy link
Contributor Author

it might should be better to just integrate jquery.ui.sortable functionality into the directive and just have jquery.ui.widget & jquery.ui.draggable as dependencies.

I would love to see that :)
I consider ui.sortable as a ui.draggable where the dropping area has a sorting behavior over its child elements.
I might try to make an experimental version of it. I keep you posted it I end up with something interesting.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants