-
Notifications
You must be signed in to change notification settings - Fork 438
Conversation
makes it easier to maintain grunt plugins
Use 'ngmin' and 'uglify' to build dist files
Use connect and watch to serve the development
Please also create an equivalent PR for the angular1.2 branch (since I`m somewhat lost in the changeset). |
You can't rebase ? |
Wait I'm doing it |
All done. |
3ff67a5 JShint pass for the sources |
fe67bb0 JShint pass for everything |
Hi @thgreasi Guess you noticed but this merging activate the 'auto publishing mode' (using the angular ui publisher) All this is for accessing to the component though bower with : # the latest build
bower install angular-ui-sortable\#bower
# the build v0.2.1
bower install angular-ui-sortable\#v0.2.1
# the master source v0.2.1
bower install angular-ui-sortable\#src0.2.1
# etc... I look forward to have your feedback on this. You're doing a great work maintaining all this I hope my changes don't hurt :) |
Oh soz @douglasduteil! I will take a look at the tagging after angular1.2 branch is pushed forward to the changes of the master branch. I`m currently doing a manual 3-way merge of the new master branch and the angular1.2. Thanks for all, hope I don't break anything. PS: Shall I re-enable the indentation check to 2 spaces, as it was before (in the angular1.2 branch)? |
@thgreasi Yep sure ! I like 2 spaces indentations 👍 |
@thgreasi What do you think about the current statue of this repo ? Have you consider making a native/pure angular version of this sortable logic ? or do you think it's a bad idea, a waist of time or an irrelevant fork ? |
@douglasduteil Just merged you changes to angular1.2 branch. (feel free to drop the rebased branch.) I think angular1.2 branch is quite mature (especially after #82). But still, not yet investigated #75... Since the angularJS 1.2 changes had a major impact to the codebase of uiSortable I have considered a rewrite. Thats because we are fighting with the ngRepeat comments and the way jquery.ui.sortable manipulated the DOM elements. Though, since I think that the feature parity that we are offering is important, it might should be better to just integrate jquery.ui.sortable functionality into the directive and just have jquery.ui.widget & jquery.ui.draggable as dependencies. |
I would love to see that :) |
No description provided.