Open
Conversation
angularsen
requested changes
Feb 27, 2026
Owner
angularsen
left a comment
There was a problem hiding this comment.
Thanks for the contribution! A couple of things need to be fixed in NominalPower.json:
1. Missing BaseDimensions
NominalPower is dimensionally equivalent to Power (W = kg·m²/s³). The quantity definition needs BaseDimensions, same as Power.json:
"BaseDimensions": {
"L": 2,
"M": 1,
"T": -3
}2. Missing BaseUnits on WattPeak
The WattPeak unit needs BaseUnits to map to SI base units, same as Power.json's Watt:
"BaseUnits": {
"L": "Meter",
"M": "Kilogram",
"T": "Second"
}Please add these and the PR should be good to go!
| private void GenerateConversionMethods() | ||
| { | ||
| Writer.WL($@" | ||
| #region Conversion Methods |
Owner
There was a problem hiding this comment.
Please don't change generator code unless intentional
| @@ -0,0 +1,25 @@ | |||
| { | |||
| "Name": "NominalPower", | |||
Owner
There was a problem hiding this comment.
Should we rename this to disambiguate this from other kinds of nominal power?
It seems maybe a bit ambiguous: https://en.wikipedia.org/wiki/Nominal_power
For example, NominalPowerPhotovoltaic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on New Unit added: Nominal Power by @McGum