Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix overridden abbrev #833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix overridden abbrev #833

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8b01d68
Add failing tests
tmilnthorp Sep 8, 2020
a625c7f
Wrap GetUnitsForAbbreviation in UnitAbbreviationsCache to allow for f…
tmilnthorp Sep 8, 2020
bc5f8c4
Fix whitespace for code consistency
tmilnthorp Sep 8, 2020
5be4cf7
Don't modify default UnitAbbreviationsCache in test
tmilnthorp Sep 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Don't modify default UnitAbbreviationsCache in test
  • Loading branch information
@tmilnthorp
tmilnthorp committed Sep 9, 2020
commit 5be4cf7052da175622f2e99e9d9fe12a67d31fd4
9 changes: 6 additions & 3 deletions UnitsNet.Tests/UnitAbbreviationsCacheTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,10 +297,13 @@ public void MapUnitToDefaultAbbreviation_GivenCustomAbbreviation_SetsAbbreviatio
}

[Fact]
public void MapUnitOverrideTest()
public void MapUnitToDefaultAbbreviation_ParsesUsingDefaultString()
{
UnitAbbreviationsCache.Default.MapUnitToDefaultAbbreviation(MassFlowUnit.GramPerSecond, NorwegianCulture, "grams/second");
Assert.Equal(MassFlow.FromPoundsPerSecond(10), Quantity.Parse(NorwegianCulture, typeof(MassFlow), "10 lb/s"));
var cache = new UnitAbbreviationsCache();
cache.MapUnitToDefaultAbbreviation(MassFlowUnit.GramPerSecond, NorwegianCulture, "grams/second");

var parser = new QuantityParser(cache);
Assert.Equal(MassFlow.FromPoundsPerSecond(10), parser.Parse<MassFlow, MassFlowUnit>("10 lb/s", NorwegianCulture, MassFlow.From));
}

[Fact]
Expand Down