Added size and opacity scaling, modified clock tickring - #9
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Three conflicts, all from the side-aware grid and drag-preview work that landed on main after this branched off 61b7180: - `cellRect` gained a `side` parameter on main and a scaled `step` here; both are kept. - `dropTarget` gained main's `preview`/`placeDisplacing` return shape, and the drop probe keeps measuring from the scaled cell. The early return for a point outside the grid now carries `preview: null` like its sibling. - `cellFromPoint`'s doc comment was auto-merged into two stacked versions; main's is the accurate one now that both grids are tried. The scale test asserted `cellFromPoint` returns `{col, row}`; it returns a `side` too since main, so the expectation names it.
`MIN_SCALE` was 0, and the editor's field went there. At zero every cell measures 0x0: nothing is drawn, and `cellFromPoint` answers null for every point on the screen, so the widgets are gone and cannot be dragged or selected back -- the only way out is the editor's own chrome. A quarter is still "as small as it goes" without being a setting that throws the grid away. The editor's field reads its bounds from the model rather than repeating them, so the two cannot drift.
anishfn
force-pushed
the
widget-scaling-tickring
branch
from
September 5, 2026 09:00
8cee90e to
954a013
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No additional widgets added.