Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@dae
Copy link
Contributor

@dae dae commented Nov 29, 2022

Copy link
Member

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good pending the backend release yes

@mikehardy mikehardy added Blocked by dependency Currently blocked by some other dependent / related change Backend Related May have something to do with Rust, related to Anki-Android-Backend labels Nov 30, 2022
Copy link
Member

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - obviously may change a bit as backend PR may change, but worth putting a preliminary approve + "seems okay to merge after a rerun of CI when backend is published" here now to indicate I've read through it all

@dae
Copy link
Contributor Author

dae commented Dec 16, 2022

After ankidroid/Anki-Android-Backend#246 is merged in and a new library published, this should be good to go once the tests are re-run.

@dae dae marked this pull request as ready for review December 16, 2022 11:08
@mikehardy mikehardy closed this Dec 18, 2022
@mikehardy mikehardy reopened this Dec 18, 2022
@mikehardy
Copy link
Member

A bit premature, I believe the new assets are in process of becoming available but they are not quite out yet
can recheck here to make sure 0.1.16-2.1.55 is out then close/reopen: https://repo1.maven.org/maven2/io/github/david-allison-1/anki-android-backend/

@mikehardy mikehardy closed this Dec 18, 2022
@mikehardy mikehardy reopened this Dec 18, 2022
@dae
Copy link
Contributor Author

dae commented Dec 19, 2022

Thanks Mike, looks like we have a successful CI run, and I've tested this locally on an M1 machine with local_backend=false, and the robolectric tests ran fine.

@mikehardy
Copy link
Member

Yep - had some unrelated windows unit test thing that was a poisoned (somehow) github actions cache, went clean after purging that + re-running. Good to go!

@mikehardy mikehardy removed the Blocked by dependency Currently blocked by some other dependent / related change label Dec 19, 2022
@mikehardy mikehardy merged commit 5193ea0 into ankidroid:main Dec 19, 2022
@github-actions github-actions bot added this to the 2.16 release milestone Dec 19, 2022
@github-actions
Copy link
Contributor

Hi there @dae! This is the OpenCollective Notice for PRs merged from 2022-12-01 through 2022-12-31

If you are interested in compensation for this work, the process with details is here:

https://github.com/ankidroid/Anki-Android/wiki/OpenCollective-Payment-Process#how-to-get-paid

We only post one comment per person per month to avoid spamming you, regardless of the number of PRs merged, but this note applies to all PRs merged for this month

Please note that GSoC contributions are okay for this process. Our philosophy is that our users have donated to AnkiDroid for all contributions. The only PRs that will not go through the OpenCollective process are ones directly related to am accepted GSoC project from a selected participant, since those receive a stipend from GSoC itself.

Please understand that our monthly budget is never guaranteed to cover all claims - the cap on payments-per-person may be lower, but we try to make our process as fair and transparent as possible, we just need your understanding.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Backend Related May have something to do with Rust, related to Anki-Android-Backend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants