-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Update to Anki 2.1.55 #12897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Anki 2.1.55 #12897
Conversation
mikehardy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good pending the backend release yes
mikehardy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - obviously may change a bit as backend PR may change, but worth putting a preliminary approve + "seems okay to merge after a rerun of CI when backend is published" here now to indicate I've read through it all
|
After ankidroid/Anki-Android-Backend#246 is merged in and a new library published, this should be good to go once the tests are re-run. |
|
A bit premature, I believe the new assets are in process of becoming available but they are not quite out yet |
|
Thanks Mike, looks like we have a successful CI run, and I've tested this locally on an M1 machine with local_backend=false, and the robolectric tests ran fine. |
|
Yep - had some unrelated windows unit test thing that was a poisoned (somehow) github actions cache, went clean after purging that + re-running. Good to go! |
|
Hi there @dae! This is the OpenCollective Notice for PRs merged from 2022-12-01 through 2022-12-31 If you are interested in compensation for this work, the process with details is here: https://github.com/ankidroid/Anki-Android/wiki/OpenCollective-Payment-Process#how-to-get-paid We only post one comment per person per month to avoid spamming you, regardless of the number of PRs merged, but this note applies to all PRs merged for this month Please note that GSoC contributions are okay for this process. Our philosophy is that our users have donated to AnkiDroid for all contributions. The only PRs that will not go through the OpenCollective process are ones directly related to am accepted GSoC project from a selected participant, since those receive a stipend from GSoC itself. Please understand that our monthly budget is never guaranteed to cover all claims - the cap on payments-per-person may be lower, but we try to make our process as fair and transparent as possible, we just need your understanding. Thanks! |
Pending ankidroid/Anki-Android-Backend#246
Obsoletes #11963