NF: rename m to noteType
#18112
Merged
NF: rename m to noteType
#18112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-allison
approved these changes
Mar 16, 2025
david-allison
requested changes
Mar 16, 2025
Comment on lines
216
to
221
| val noteType = this@Card.noteType(col) | ||
| return if (noteType.isStd) { | ||
| noteType.tmpls[ord] | ||
| } else { | ||
| noteType(col).tmpls[0] | ||
| this@Card.noteType(col).tmpls[0] | ||
| } |
Member
There was a problem hiding this comment.
! This looks like a minor performance issue upstream, but it doesn't match
noteType is ONLY used inside the if
def template(self) -> TemplateDict:
notetype = self.note_type()
if notetype["type"] == MODEL_STD:
return self.note_type()["tmpls"][self.ord]
else:
return self.note_type()["tmpls"][0]
Member
Author
There was a problem hiding this comment.
I corrected this upstream https://github.com/ankitects/anki/blob/d52889f45c3f7999a45fd2dde367f79f3bc3bad4/pylib/anki/cards.py#L175
Member
There was a problem hiding this comment.
Still not updated to follow the new code of the upstream method.
Arthur-Milchior
added a commit
to Arthur-Milchior/anki
that referenced
this pull request
Mar 16, 2025
As AnkiDroid wants to be similar to Anki, instead of making AnkiDroid slightly less efficient, I prefer to slightly improve Anki. AnkiDroid related PR: ankidroid/Anki-Android#18112.
abdnh
pushed a commit
to ankitects/anki
that referenced
this pull request
Mar 19, 2025
As AnkiDroid wants to be similar to Anki, instead of making AnkiDroid slightly less efficient, I prefer to slightly improve Anki. AnkiDroid related PR: ankidroid/Anki-Android#18112.
d0edeb4 to
1c0d753
Compare
Contributor
|
Hello 👋, this PR has had no activity for more than 2 weeks and needs a reply from the author. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 7 days until this gets closed automatically |
lukstbit
approved these changes
Apr 7, 2025
Member
lukstbit
left a comment
There was a problem hiding this comment.
As this got stale I decided to fix it to move things along.
david-allison
approved these changes
Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some more part of #17598