Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat(card-browser): Grade now #18914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mikehardy merged 2 commits into from
Jul 20, 2025
Merged

feat(card-browser): Grade now #18914

mikehardy merged 2 commits into from
Jul 20, 2025

Conversation

@david-allison
Copy link
Member

@david-allison david-allison commented Jul 18, 2025 •
edited
Loading

Purpose / Description

Allows a user to grade a card without the use of the study screen

Fixes

Approach

Converted/copied

How Has This Been Tested?

API 34 Tablet Emulator, manually

Card Info is updated
Different buttons post different grades
Undo works

Screenshot 2025-07-18 at 15 18 19 Screenshot 2025-07-18 at 15 18 46 Screenshot 2025-07-18 at 15 43 10

Checklist

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@david-allison
feat(card-browser): Grade Now
f1f1589 
Allows a user to grade a card without the use of
 the study screen

Issue 18604
ShridharGoel
ShridharGoel reviewed Jul 20, 2025
View reviewed changes
AnkiDroid/src/main/java/com/ichi2/anki/dialogs/GradeNowDialog.kt
context: AppCompatActivity,
cardIds: List<CardId>,
) {
if (!cardIds.any()) {
Copy link
Member

@ShridharGoel ShridharGoel Jul 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: can use cardIds.isEmpty()

@ShridharGoel ShridharGoel added Needs Second Approval Has one approval, one more approval to merge and removed Needs Review labels Jul 20, 2025
mikehardy
mikehardy approved these changes Jul 20, 2025
View reviewed changes
Copy link
Member

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feature completeness +1

@mikehardy mikehardy added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) Anki Ecosystem Compatibility and removed Needs Second Approval Has one approval, one more approval to merge labels Jul 20, 2025
@mikehardy mikehardy added this pull request to the merge queue Jul 20, 2025
Merged via the queue into ankidroid:main with commit 990fb2f Jul 20, 2025
10 checks passed
@github-actions github-actions bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Jul 20, 2025
@github-actions github-actions bot added this to the 2.22 release milestone Jul 20, 2025
@david-allison david-allison deleted the grade-now branch July 20, 2025 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mikehardy mikehardy mikehardy approved these changes

@ShridharGoel ShridharGoel ShridharGoel approved these changes

Assignees

No one assigned

Labels

Anki Ecosystem Compatibility

Projects

None yet

Milestone

2.22 release

Development

Successfully merging this pull request may close these issues.

Add 'Grade Now' to Browser

3 participants

@david-allison @mikehardy @ShridharGoel