Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: discard changes was shown if note contained a newline #20250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mikehardy merged 1 commit into from
Jan 30, 2026
Merged

fix: discard changes was shown if note contained a newline #20250

mikehardy merged 1 commit into from
Jan 30, 2026
+38 −1

Conversation

@david-allison
Copy link
Member

@david-allison david-allison commented Jan 29, 2026 •
edited
Loading

Purpose / Description

<br> in the collection was converted to \n in the EditText, these weren't comparable

Fixes

Approach

git bisect
Then write a test
Then fix a test
Then write more tests

How Has This Been Tested?

Tests

Checklist

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@david-allison david-allison force-pushed the 20174-newline-discard-changes branch from ccc71f2 to 559f510 Compare January 29, 2026 02:47
@david-allison david-allison added the Review High Priority Request for high priority review label Jan 29, 2026
@david-allison david-allison changed the title fix: discard changes is not shown if note contains a newline fix: discard changes was shown if note contains a newline Jan 29, 2026
@david-allison david-allison force-pushed the 20174-newline-discard-changes branch from 559f510 to d8a2cd9 Compare January 29, 2026 20:54
@david-allison
fix: discard changes was shown if note contained a newline
da92dc4 
`<br>` in the collection was converted to `\n` in the
EditText, these weren't comparable

Fixes 20174
@david-allison david-allison force-pushed the 20174-newline-discard-changes branch from d8a2cd9 to da92dc4 Compare January 29, 2026 20:54
@david-allison david-allison changed the title fix: discard changes was shown if note contains a newline fix: discard changes was shown if note contained a newline Jan 29, 2026
mikehardy
mikehardy approved these changes Jan 30, 2026
View reviewed changes
Copy link
Member

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

git bisect
Then write a test
Then fix a test
Then write more tests

This is The Way

@mikehardy mikehardy added this pull request to the merge queue Jan 30, 2026
@mikehardy mikehardy added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Review High Priority Request for high priority review Needs Review labels Jan 30, 2026
Merged via the queue into ankidroid:main with commit 2529cac Jan 30, 2026
15 checks passed
@github-actions github-actions bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Jan 30, 2026
@github-actions github-actions bot added this to the 2.24 release milestone Jan 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mikehardy mikehardy mikehardy approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.24 release

Development

Successfully merging this pull request may close these issues.

Unconditional discard changes when closing note editor

2 participants

@david-allison @mikehardy