Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Mathjax editor improvements #1502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dae merged 20 commits into from
Nov 23, 2021
Merged

Mathjax editor improvements #1502

dae merged 20 commits into from
Nov 23, 2021

Conversation

@hgiesel
Copy link
Contributor

@hgiesel hgiesel commented Nov 22, 2021

Improvements:

  • Supports pressing Enter to accept Mathjax, Shift-Enter for newline
  • Show this information as placeholder on empty Mathjax
  • Give Mathjax a min-width for less resizing on small sizes (and no resize when placeholder disappears)
  • Delete button
  • Only use one ResizeObserver for all Mathjax images (hopefully closes mathjax editor is leaking memory #1491 ?)

Unrelated:

  • Add bazel directories to .prettierignore and run from root once. This formatted json and css files in rslib and ftl. I've executed it by accident on the root sometimes, which formatted bazel files, which broke bazel for me. I saw no reason not to include those files in other directories in formatting.

hgiesel and others added 20 commits November 18, 2021 21:23
@hgiesel
Remove unnecessary stopPropagation of mathjax-overlay events
6f43658
@hgiesel
Use CodeMirror component for MathjaxHandle
4266d36
@hgiesel
Refactor ResizeObserver code in MathjaxHandle
1bcf03f
@hgiesel
Wrap setRange in CodeMirror in try/catch
ad1ca5e
@hgiesel
Add Mathjax Editor bottom margin
6f96ffc
@hgiesel
Add custom Enter and Shift+Enter shortcuts for the MathjaxHandle
aacf680
@hgiesel
Format
fc607b8
@hgiesel
Move placeCaretAfter to domlib
7973880
@hgiesel
Move focus back to field after editing Mathjax
9943b74
@hgiesel
Put Cursor after Mathjax after accepting
dfc00bb
@hgiesel
Add delete button for Mathjax
a543a8f
@hgiesel
Change border color of mathjax menu
72c1272
@hgiesel
Refactor into MathjaxMenu
7222a61
@hgiesel
Put caretKeyword in variable
43ca792
@hgiesel
Use one ResizeObserver for all Mathjax images
8798644
@hgiesel
Add minmimum width for Mathjax editor
1e06a0d 
* is still smaller than minimal window width
@hgiesel
Add bazel directories to .prettierignore and format from root
d60f45c
@dae
Merge branch 'main' into mathjaxeditorfixes
7e31fc7
@dae
exclude ftl/usage
a2d4e4d 
the json files that live there are output from our tooling, and
formatting them means an extra step each time we want to update them

also exclude .mypy_cache, which is output by scripts/mypy*
@dae
minor ftl tweak: newline -> new line
2fffcc2
@dae
Copy link
Member

dae commented Nov 23, 2021

Thanks Henrik!

@hikaru-y does this resolve the mem leak for you?

@dae dae merged commit 2778b92 into ankitects:main Nov 23, 2021
@dae
Copy link
Member

dae commented Nov 23, 2021

This introduced a warning during build - maybe we could work around it with a temporary variable?

Warning - unrecognized UnaryExpression operator 40!
This is an edge case unaccounted for in svelte2tsx, please file an issue:
https://github.com/sveltejs/language-tools/issues/new/choose
-$imageHeight

@hikaru-y
Copy link
Contributor

hikaru-y commented Nov 23, 2021

@dae
I tried the latest main branch(675155e), and unfortunately the issue(#1491) remains. I looked into the cause a bit. It appears that the MathJax images (SVG data URI) are cached in memory and are not released until the end of the session. I think this is because the contents are dynamically rewritten in the editor, and a page refresh never happens.

Screenshot (DevTools)

mathjax-editor

To be honest, I'm not sure if this is an issue that needs to be solved or not, because the amount of memory usage that increases each time a card is selected is so small that it shouldn't be a big problem for users unless they select hundreds of cards in total.

@dae
Copy link
Member

dae commented Nov 24, 2021

Thanks for checking. If the leak is small and does eventually get cleaned up, I think you're probably right that we don't need to worry about it.

@hgiesel hgiesel deleted the mathjaxeditorfixes branch November 24, 2021 02:30
@iamllama iamllama mentioned this pull request Feb 18, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

mathjax editor is leaking memory

3 participants

@hgiesel @dae @hikaru-y