Debounce mathjax rendering to avoid stalling #3827
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dae
reviewed
Feb 18, 2025
ts/editable/Mathjax.svelte
Outdated
| import { pageTheme } from "$lib/sveltelib/theme"; | ||
|
|
||
| import { convertMathjax, unescapeSomeEntities } from "./mathjax"; | ||
| import { ChangeTimer } from "../editor/change-timer"; |
Member
There was a problem hiding this comment.
While not a problem at the moment as we have a single compilation unit, this is introducing a circular dependency. change-timer would be better moved to editable or something like sveltelib.
010e642 to
f0fd95e
Compare
Member
|
Thanks :-) |
mattfengsh
added a commit
to mattfengsh/anki
that referenced
this pull request
Feb 21, 2025
commit 76c4ec7 Author: Damien Elmes <[email protected]> Date: Fri Feb 21 18:29:41 2025 +0700 Add actions-processing based on qt-misc-processing commit a7c5376 Author: Damien Elmes <[email protected]> Date: Fri Feb 21 18:21:28 2025 +0700 Update translations commit 00cc1b4 Author: GithubAnon0000 <[email protected]> Date: Fri Feb 21 10:14:15 2025 +0000 Increase font size for accessibility (ankitects#3832) Apparently no font size should be lower than 12px, see https://www.boia.org/blog/accessibility-tips-let-users-control-font-size. With the current 55%, I get a computed font size of 8.25px though. Considering the text shows the helpful message "Press Enter to accept, Shift+Enter for new line.", I think we should add a minimum font size. commit 8ec139f Author: llama <[email protected]> Date: Fri Feb 21 17:39:11 2025 +0800 Debounce mathjax rendering to avoid stalling (ankitects#3827) * move change-timer to editable * debounce mathjax rendering commit e373b0e Author: mumtazrifai <[email protected]> Date: Fri Feb 21 04:38:04 2025 -0500 Use default flag name when flag is renamed to empty string (ankitects#3826) * Add function to restore the default name of a flag * Call function to restore default flag name if flag renamed to empty string * Update _load_flags to use the default_flag_names dict * Add name to contributors file * Add trailing comma to pass tests * Update to follow python style guide * Update about.py * Revert "Update _load_flags to use the default_flag_names dict" This reverts commit caa8fea. * Use require_refresh() instead of storing default flag names commit 2727cf3 Author: Damien Elmes <[email protected]> Date: Fri Feb 21 10:33:57 2025 +0700 Update to Rust 1.85 Edition update to follow later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3803
Typing in the mathjax editor causes it to rerender, which can be slow when done per character, given a large enough expression
This pr proposes to debounce rendering to svg by 500ms to avoid stalls