-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Feat/support load balance and easy days in FSRS simulator #3829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/support load balance and easy days in FSRS simulator #3829
Conversation
|
At first glance, same as #3815 - no support for the |
Nice, that is a cleaner solution.
I can't think of a better place to put it for now. What about instead of embedding it in the page, you have a clickable "Simulator" link that displays it as as a larger pop-over on the page? |
Fixed in 59d5ef0
Sounds good. But I need help. I don't know how to develop that. |
|
An example of how to do that is TextInputModal.svelte, which is used in ConfigSelector.svelte Associated docs: https://getbootstrap.com/docs/5.0/components/modal/ |
|
Regarding the readibility issue, I believe that introducing a As for the Update: I understand that implementing a configurable |
Co-authored-by: Luc Mcgrady <[email protected]>
|
But I don't know why the ticks become larger when I zoom out the window:
Edit: It's caused by this code anki/ts/routes/graphs/Graph.svelte Lines 39 to 58 in 8e13e6b
But I don't know the purpose. |
- Update fsrs-rs dependency to latest commit - Modify retention and simulator modules to use Arc instead of Box - Update function signatures and imports in simulator module - Simplify review card order handling with direct enum usage
|
We should add a tooltip to clarify that the "Smooth" toggle only affects the graph and has nothing to do with actual scheduling. |
|
Or a variant of that idea - what if the simulator-specific options are shown at the top, with everything else in a disclosure/hidden by default section? Again, no strong feelings here - "no" is an acceptable answer. |
IMO, yes. The user might want to play with these values to see the effect on their future workload without wanting to change the actual settings. Also, if the user has to change the values scattered throughout the deck options page, the simulator would become difficult to use. |
|
Regarding the easy days: As user1823 pointed out, users might want to experiment with settings in the simulator. However, when it comes to easy days, users are unlikely to adjust them frequently. They already know which days are busy for them, so there’s no need to display these settings again on the simulator page. Objectively, the simulator is a tool for exploration - users can play with it to find their ideal settings, which is why the adjustable options are present on this page. The "Save to Preset Options" button is there just to save users from having to remember the values they set in the pop-up to transfer to the main settings page . Since users don’t need to recall which days they’re busy, there’s no reason to duplicate the easy days settings on the simulator page. Something like that. Personally, I like the current set of the adjustable settings. For me, By the way, perhaps this is the right moment to implement the |
But we need to convey that Easy Days affect the simulation. Plus, as you said, the simulator is a tool for exploration, so I'd say we should add Easy Days sliders to the simulator. |
It is already obvious, if I will suggest to set the |
I wanted, but the screen is too crowded now. |
|
Reviewing now. Are you planning to release the updated fsrs-rs on crates.io? If so, it would be nice to point to that instead of a git commit. (if it's still in progress, we can point to a git commit for now, but that would be nice to fix before the next stable release) |
dae
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of minor points and then good to go on my end 👍
Assuming that's a no for now, so I'll merge this in. |
|
Thank you for your work on this as always! |
Yeah, because @Luc-Mcgrady added more features into the simulator: So the simulator is still not stable now. I plan to update fsrs-rs on crates.io in the next month. |








Key Changes
post_scheduling_fnto simulator that applies load balance and easy daysTODO
Refactor simulator daily stats chart
Review post_scheduling_fn implementation
Consider moving simulator to dedicated page
Related Issues
Preview: