Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@Luc-Mcgrady
Copy link
Contributor

Adds the "Suspend after X leeches" feature to the simulator.

Limits for examples:
(1: no limit, 2: 14, 3: 7, 4: 100)
image
image

@user1823
Copy link
Contributor

As the number of settings that influence the simulation continue to grow, I am beginning to like dae's suggestion here:

Are there any where it might make sense to show them in a more concise, read-only form? E.g. something like the following in small grey text: "Other influencing settings: 20 new cards/day, 200 reviews/day, 2 easy days, max interval 36500, ..."?

Originally posted by @dae in #3829 (comment)

Though it's important to include settings like limits per day and max interval in the simulator page, we can put the minor settings like easy days and leech actions in small grey text at the bottom.

@Luc-Mcgrady
Copy link
Contributor Author

How about something as simple as an "Advanced settings" drop down?
image
image

@user1823
Copy link
Contributor

Works for me 👍

@YukiNagat0
Copy link
Contributor

YukiNagat0 commented Feb 27, 2025

Maybe move Max interval to main list, instead of advanced drop down?
Everything else looks good

@L-M-Sherlock
Copy link
Contributor

I haven't seen the dropdown of "Easy Days". Did you push the commit?

@Luc-Mcgrady
Copy link
Contributor Author

I included that as a placeholder for the image and then forgot to implement it 😅.

@Luc-Mcgrady
Copy link
Contributor Author

Should be there now.
image
Also made the header sticky so that you can exit out without scrolling up.

@Expertium
Copy link
Contributor

Will there be tooltips in this window?

@Luc-Mcgrady
Copy link
Contributor Author

Peek 2025-03-01 12-55
Tooltips for which part? There is the help modal (which opens behind the simulator modal (?)).

@dae
Copy link
Member

dae commented Mar 10, 2025

Thanks for your work on this @Luc-Mcgrady. Some minor issues/thoughts I noticed:

  • the graph is truncated by default in my window - the x axis labels aren't visible
  • if we're going to have a 'save to preset options' button, it should work on all settings like max interval as well
  • nested disclosures (easy days in advanced) gets a bit confusing. Do we need both?
Screenshot 2025-03-10 at 2 08 14 pm

@Luc-Mcgrady
Copy link
Contributor Author

the graph is truncated by default in my window - the x axis labels aren't visible

Is scrolling down an issue? I can't see scroll bars on your image like I can on mine.
image

if we're going to have a 'save to preset options' button, it should work on all settings like max interval as well

I can't take credit for that feature but I believe it already does.
https://github.com/ankitects/anki/blame/cad6e0b0bfd0b0b4c4777db20678bd066ad21f39/ts/routes/deck-options/SimulatorModal.svelte#L296

nested disclosures (easy days in advanced) gets a bit confusing. Do we need both

I'll keep both but move easy eays out of the advanced section.

@dae
Copy link
Member

dae commented Mar 14, 2025

Is scrolling down an issue? I can't see scroll bars on your image like I can on mine.

Scrollbars are hidden on a Mac by default. I've made some tweaks to the layout that seems to fix the starting height for me - does that work for you? Otherwise good to go on my end.

I can't take credit for that feature but I believe it already does.

Sorry, I tested it earlier and it didn't work, but that's because I tried increasing the limit and it was already at its max.

@YukiNagat0
Copy link
Contributor

Issues Encountered:

  1. Unexpected Scroll Behavior
    With latest commit (f37206a) it is harder to observe, but you can scroll the Options for Deck window while interacting with the FSRS simulator. The attached recording demonstrates this behavior, where the secondary scrollbar (from the Options window) moves independently.
Scroll.mp4
  1. Graphical Artifacts on Windows
    When using Direct3D or Vulkan video drivers artifacts on Windows you can sometimes observe video artifacts - it is not a new thing, but it was never addressed. However, I've noticed that specifically on the FSRS simulator pop-over that artifacts are significantly worse: appear very often and cover all the screen. These artifacts are absent when switching to OpenGL or Software video drivers .
Artifacts_.mp4

@dae
Copy link
Member

dae commented Mar 14, 2025

Some CSS wizard may be able to resolve the former issue. The latter issue is with that video driver, and not something we really have the power to control AFAIAA.

@YukiNagat0
Copy link
Contributor

The latter issue is with that video driver, and not something we really have the power to control AFAIAA.

Speaking of video drivers, do you know if it has become possible to add fullscreen support for OpenGL? On my machine OpenGL seems to be the most stable, but what keeps me from using it is the fact that it does not support fullscreen.

@Luc-Mcgrady
Copy link
Contributor Author

does that work for you? Otherwise good to go on my end.

LGTM! 🚀

@dae dae merged commit 79b6f65 into ankitects:main Mar 15, 2025
1 check passed
@dae
Copy link
Member

dae commented Mar 15, 2025

I'd be surprised if Qt had fixed the full screen issues. You can check yourself by removing the check inside Anki.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants