feat: add title to some of the sync dialogs #3838
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sync iniates in the `Checked` state, so the initial title is changed to match it instead of using the generic `Anki` title
Maybe a new string should be created for that.
Maybe a new string should be used for that
Contributor
Author
|
https://buildkite.com/ankitects/anki-ci/builds/9813
Apparently the script needs to handle different casing. Or just use the GitHub ID instead of trying to get the user name as well. |
Even in 2025, the script isn't smart enough to handle different casing or use just the GitHub ID
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: I use Windows 11 and komorebi as my window manager. It can differentiate windows by executable, window class, and window title. The issue is that many Anki windows spawn with
Ankias title and change it later, so the program can't differentiate them when they spawn. Also, there are dialogs/windows without a proper title, like the sync conflict dialog.So I propose changing the title of some of the sync dialogs. Despite of my original reason, I think that the titles should be improved anyway.
The changes are described in the commits