Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add title for some dialogs and avoid hardcoding the text of the discard changes dialog #3846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dae merged 6 commits into from
Mar 10, 2025
Merged

Add title for some dialogs and avoid hardcoding the text of the discard changes dialog #3846

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
009e694
feat: add title to rename dialog
BrayanDSO Mar 7, 2025
ce3b0d9
fix: localize hardcoded message
BrayanDSO Mar 7, 2025
f357a19
feat: add title to create deck dialog
BrayanDSO Mar 7, 2025
6275599
refactor: formatting fixes
BrayanDSO Mar 7, 2025
7eb2d3c
add name to about screen
BrayanDSO Mar 7, 2025
ae31374
Merge branch 'main' into more-dialogs
dae Mar 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
feat: add title to rename dialog
  • Loading branch information
@BrayanDSO
BrayanDSO committed Mar 7, 2025
commit 009e6949d9ea0db07aaec509b013dc4c47009d40
2 changes: 1 addition & 1 deletion qt/aqt/deckbrowser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,7 +328,7 @@ def _export(self, did: DeckId) -> None:

def _rename(self, did: DeckId) -> None:
def prompt(name: str) -> None:
new_name = getOnlyText(tr.decks_new_deck_name(), default=name)
new_name = getOnlyText(tr.decks_new_deck_name(), default=name, title=tr.actions_rename())
if not new_name or new_name == name:
return
else:
Expand Down