Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Added: Max interval too low warning. #3847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dae merged 5 commits into from
Mar 10, 2025
Merged

Added: Max interval too low warning. #3847

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
783d477
Added: Max interval too low warning.
Luc-Mcgrady Mar 7, 2025
8d74434
Lower threshold to 180
Luc-Mcgrady Mar 7, 2025
6f086a3
Add self to about.py
Luc-Mcgrady Mar 9, 2025
eb5ab7f
Merge branch 'main' into max-interval-warning
dae Mar 10, 2025
df58625
Merge branch 'main' into max-interval-warning
dae Mar 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ftl/core/deck-config.ftl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,6 +371,7 @@ deck-config-learning-step-above-graduating-interval = The graduating interval sh
deck-config-good-above-easy = The easy interval should be at least as long as the graduating interval.
deck-config-relearning-steps-above-minimum-interval = The minimum lapse interval should be at least as long as your final relearning step.
deck-config-maximum-answer-secs-above-recommended = Anki can schedule your reviews more efficiently when you keep each question short.
deck-config-too-short-maximum-interval = A maximum interval less than 6 months is not recommended.

## Selecting a deck

Expand Down
1 change: 1 addition & 0 deletions qt/aqt/about.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,6 +215,7 @@ def on_dialog_destroyed() -> None:
"Danika_Dakika",
"Marcelo Vasconcelos",
"Mumtaz Hajjo Alrifai",
"Luc Mcgrady",
"Brayan Oliveira",
)
)
Expand Down
13 changes: 13 additions & 0 deletions ts/routes/deck-options/AdvancedOptions.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html
import SpinBoxFloatRow from "./SpinBoxFloatRow.svelte";
import SpinBoxRow from "./SpinBoxRow.svelte";
import DateInput from "./DateInput.svelte";
import Warning from "./Warning.svelte";

export let state: DeckOptionsState;
export let api: Record<string, never>;
Expand Down Expand Up @@ -83,6 +84,13 @@ License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html
};
const helpSections: HelpItem[] = Object.values(settings);

$: maxIntervalWarningClass =
$config.maximumReviewInterval < 50 ? "alert-danger" : "alert-warning";
$: maxIntervalWarning =
$config.maximumReviewInterval < 180
? tr.deckConfigTooShortMaximumInterval()
: "";

let modal: Modal;
let carousel: Carousel;

Expand Down Expand Up @@ -121,6 +129,11 @@ License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html
</SpinBoxRow>
</Item>

<Item>
<Warning warning={maxIntervalWarning} className={maxIntervalWarningClass}
></Warning>
</Item>

{#if !$fsrs}
<Item>
<SpinBoxFloatRow
Expand Down