Fix cargo ignoring lockfile when building syncserver image #3856
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Tested this solution, it works! Thanks for looking into this. Btw, be sure to also update the |
Co-authored-by: Simon <[email protected]>
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3854
Was able to reproduce. fsrs-rs' indirect dep priority-queue bumped its edition from 2021 to 2024 in a patch version recently, and although anki's lockfile has it pinned to 2.1.1, cargo ignores the lockfile when installing if the
--lockedflag isn't passed to itWhen building the sync server image,
2.1.1in fsrs-rs' Cargo.toml is equivalent to^2.1.1, so cargo pulls 2.2.2, which it can't handle yet (on 1.83)The fix proposed is to pass the
--lockedflag to cargo in the dockerfile