Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix/incorrect initialization of SchedTimingToday in graphs/retrievability.rs #3857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dae merged 1 commit into from
Mar 14, 2025
Merged

Fix/incorrect initialization of SchedTimingToday in graphs/retrievability.rs #3857

dae merged 1 commit into from
Mar 14, 2025

Conversation

@L-M-Sherlock
Copy link
Contributor

@L-M-Sherlock L-M-Sherlock commented Mar 12, 2025 •
edited
Loading

Found in https://forums.ankiweb.net/t/bug-retrievability-in-browser-doesnt-match-retrievability-in-stats-histogram/56547/5?u=l.m.sherlock

The next_day_at is used here:

anki/rslib/src/browser_table.rs

Lines 129 to 134 in 9b5da54

pub(crate) fn days_since_last_review(&self, timing: &SchedTimingToday) -> Option<u32> {
if !self.is_due_in_days() {
Some(
(timing.next_day_at.0 as u32).saturating_sub(self.original_or_current_due() as u32)
/ 86_400,
)

@ghrgriner ghrgriner mentioned this pull request Mar 12, 2025
Open
@dae dae merged commit 33b8235 into ankitects:main Mar 14, 2025
1 check passed
@L-M-Sherlock L-M-Sherlock deleted the Fix/incorrect-initialization-of-SchedTimingToday-in-graphs/retrievability.rs branch March 14, 2025 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@L-M-Sherlock @dae