Add-ons Dialog: disable View Config/Page/Files buttons when clicking them would not lead to useful result #3869
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
I was getting confused while working with add-on configs, files, etc. often clicking the buttons without having any add-ons selected, and getting the
please_select_a_single_addon_firstpop-up. Perhaps this could improve the usability of the dialog, if buttons were only clickable when clicking them would lead to a useful action.How
itemSelectionChangedhandler because it is also triggered on empty selection, etc.currentRowChangedhandler to preserve the hook’s behavior. But moved the button-disabling logic to the new handler.Note that now it would theoretically be possible to remove the
onlyOneSelectedfunction. 📝I hope, my code is not too sloppy (and I am sorry for doing multiple things, like adding the Cmd+W shortcut, in the same PR). Big thanks to the Anki team for all their effort! 🙌
Before:
Note that when multiple add-ons are selected, the state of Page and Config buttons depends on which add-on is the first among the selected ones.
Screen.Recording.2025-03-16.at.22.53.46.mov
After:
Screen.Recording.2025-03-17.at.00.08.05.mov