-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Add help modal to TR table #3874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Is it really a necessary change? As you have noted in the thread, the True Retention Table is already documented in the Anki Manual, and the term "True Retention" itself inherently suggests it represents actual/real retention metrics, in contrast to the "Desired Retention". I believe adjusting the graph order (#3873) would sufficiently address the core concern about clarity without introducing redundant explanations (which would also require translatorsβ work for this string). Team: "Clear UI" and "Read the Documentation" |
I do agree. But it's difficult for me to know what a "normal" user would or wouldn't do, and apparently "normal" users struggle with basic research. Also: "True Retention" might not be as obvious for users without a background in psychology / spaced repetition, or for those that never read the manual ect. Maybe @Expertium could help shed light? Would just switching the order of the graphs be enough? |
|
As far as I know, only one user has expressed uncertainty about how to check their True Retention: https://forums.ankiweb.net/t/let-s-remove-the-answer-buttons-chart-from-stats/56170/23 To put it briefly: very low value, but a significant impact on the UI. |
Well, guess it's time for another survey. I'll make it tomorrow |
I don't think that these surveys are representing reality: they are testing only the small Anki community on reddit. The thing is that people who don't have problems understanding Anki just don't read the Anki reddit or any community network (including Anki forum). So, basically, every survey on "Help Me"-style social network will be biased. |
Yes, the participants are people from r/Anki: a subreddit for Anki enthusiasts, for people who care about Anki enough to comment and post. Which means an average r/Anki regular is more familiar with Anki than a completely randomly selected Anki user. Which means that a randomly selected Anki user is more likely, not less likely to struggle with Anki. If r/Anki regulars struggle, it's a safe bet that people who aren't Anki enthusiasts struggle even more. |
In my opinion *(or rather from my observations), 90% of users on the r/Anki are people how don't want to read the docs and just want to get answer without any effort, prove me wrong. |
|
Alright, I posted it on r/Anki and in the Anki Discord server. Link to the summary of results: https://docs.google.com/forms/d/1pvIxywJDzZ_-DddyYg9eA0TiVMW749MsrfK_F_2NuMA/viewanalytics |
|
@GithubAnon0000 can you make a hint that shows the text when you click on the question mark? Another good suggestion from jake: https://forums.ankiweb.net/t/let-s-remove-the-answer-buttons-chart-from-stats/56170/46?u=expertium |
|
Please, don't remove anything. |
I've mentioned before that I don't think these are well-placed assumptions. You can't assume that a randomly selected user understands less -- it's just as likely they understand more, and they aren't showing up in these help-venues because they don't have any problem understanding. Plus, there are plenty of "enthusiasts" who read about Anki every day and still don't understand it very well (and give poor advice because of it). |
|
I appreciate the idea of this change, but it still seems unnecessary to me. Part of the value of the Stats page is how much it is focused on images, not words -- on presenting the data, not interpreting it. We've had Answer Buttons as the "check your retention" spot for many, many years without needing to import text like that from the manual. I think the True Retention table can stand on its own too. I also think the text that is already there -- [As an aside on the text of the PR: But perhaps more importantly: |
|
Last time I checked the results they were different: The proportion of "No" to "Yes" for confusion about |
According to the new results, it's quite even:
I can surely try. You should know, though, that my coding skills aren't the best in the world β so I might not be able to implement this. I'll try though and let you know. There a huge but though: People already fail to read that info in the deck option (e.g. where you set your DR). Do you really think this is going to do any good? I must say I doubt it.
I don't think this is really justifiable considering ~69% of people voted for "do not change anything".
I agree, it is backwards. I didn't notice because I just took the text from the manual. I'll change it here and in the manual. |
It's better than nothing, at least. |
|
Results were falsificated! |
|
...you have to be kidding me |
|
No you! Why you didn't stop the poll after you posted the results??? |
|
Why? We don't have to close the survey or make a decision right now. We can keep looking at results as more and more people participate. |
|
It's wrong to continue survey after you post the results! |
|
Again - why? That's like saying "refreshing the page is wrong" |
|
BIAS. Some participants have already seen the results before starting the survey. |
It's true that results shouldn't be puplically viewable, if this was a scienctifically done study. I'd like to point out, however, that results could have been viewed since the very first participant. It even shows a "view the results" button at the end of the survey. But is it really likely that this is going to be a confounding variable here? Maybe we should take the poll with a grain of salt and just look at tendencies instead. |
Participants can view the summary only after submitting their response. Unless you mean that they saw it here, on Github. But I doubt that anyone other than the three of us and Danika are looking here. |
THEY CAN'T PARTICIPATE AGAIN AFTER FINISHING THE SURVEY. |
It's for when multiple subheadings open the same modal, e.g in deck options. Not necessary right now, but I recommend you add it back to keep things consistent with everywhere else |
Comming back to this (I cannot believe an entire month already passed): The checks won't pass if I add it back because if I add it back, then the eslint throws an error (unused code). I could solve this if I could figure out how to make the title clickable. I attempted quite a few options and none really worked. If you look at my last commit and build it, you can see that the message
gets printed whenever I try to open the stats (and the graphs won't show up). Does someone here know how to generally add clickable text or can even help a bit? Another thing: I cannot
Did I mess something up? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can provide a full diff if this doesn't work?
Co-authored-by: Luc Mcgrady <[email protected]>
Co-authored-by: Luc Mcgrady <[email protected]>
Co-authored-by: Luc Mcgrady <[email protected]>
|
Thanks @Luc-Mcgrady, this works flawlessly! I'm still getting messages like
if I run This is ready for review now. |
|
Looks good - thank you! Regarding your issues with ./check, removing the .venv folder you've placed there should fix it. |
Not sure how it got there since I didn't create it manually. It also seems to exist since 22. Feb. 2025 β but I didn't have this issue with I did remove it now and that indeed solved the issue. Thank you! |
|
Probably created with a tool like |










This adds additional info as clarification, which was taken from the anki manual.
Also see:
https://forums.ankiweb.net/t/let-s-remove-the-answer-buttons-chart-from-stats/56170/24?u=anon_0000
Edit: This has been converted into a help modal instead. See #3874 (comment).