Center align rows in FSRS simulator #3882
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
My two cents: at this point it might be better to seriously reconsider the simulator ui as a whole in the forum rather than splitting the discussion on each individual aspect of the simulator over individual prs. This makes it harder for transparent discussion to occur, and to gauge if the UI change is actually supported by the majority of the community, and not just a handful of people. pinging @Luc-Mcgrady because it concerns the "smooth graph" change as well |
Member
|
Agreed that this might be better discussed in more general terms, but for now this seems like an uncontentious change, if people were to notice at all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I confused two rows with each other in the simulator because the option name and option toggle / textfields are quite some distance apart on my screen. My eyes followed the wrong imaginary line between name and toggle.
This PR centers the row strings. That way, the option name and option toggle / textfields are better aligned. The change is small but helps me a tiny bit.
Before:
After:
Yes, one can barely see the difference. I'd prefer having a better distinction between rows or some way to make it more obvious which row elements belong to each other. But I don't know how to achieve that, while still having some aesthetics.