Some documentation and reduce copy/paste #3917
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5f0af05 to
e13c082
Compare
Contributor
|
Wasn't this issue already solved by #3890? |
Contributor
Author
|
It seems so. I looked for this march 16 when I opened the bug in ankidroid. I had no idea that somebody solved it in the meantime. Wonderful. |
I needed to know because {{c1 generate card 0 for example. And storing
the card ordinal would have been another consistent choice.
e13c082 to
adc3f72
Compare
Contributor
Author
|
Also, we'll need to check. But given that we have always a small cost to pay to send request to the back-end, a method that returns all data may be better than having to send one request by template, especially as long as it does not provide a way to send multiple request as a batch. But i'll see whether it makes sense when we can actually test the feature |
This slightly reduce code duplication.
adc3f72 to
8e6351c
Compare
dae
reviewed
Apr 24, 2025
Member
If it proves necessary in the future, we can always add it then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR initially offered to solve an already solved issue that I missed.
The first two commits were some clean-up that I believe are still improving the codebase, so I keep this PR open but removed the last commit.
Here is the original description:
Introduce get_non_empty_card_indexes
This method takes a note type id and the content of fields. It returns
the order of the cards that would be non-empty according to this note.
To be more specific, for cloze type, it return any cloze
number (except 0), even if it does not appear in a cloze field, in
order to be consistent with the way anki generates note.
For normal type, for each template, it returns whether the card would
be generated, and also whether the template has an error.
The goal here is to allow ankidroid to display in the note editor's
previewer which card will be generated. Which is done currently by
checking whether the "empty card" message appear in the previewer,
which is not ideal.
Please let me know whether you'd accept this service. In which case I'll add a few tests with the default note type. I preferred not to spend more time adding tests until I know whether it'd be useful or not