Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix fields with \n being ignored when searching all fields w/o regex #3943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dae merged 2 commits into from
Apr 24, 2025
Merged

Fix fields with \n being ignored when searching all fields w/o regex #3943

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
38eda25
add singleline flag to regex when searching all fields
iamllama Apr 24, 2025
e28a8e6
update test
iamllama Apr 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
add singleline flag to regex when searching all fields
  • Loading branch information
@iamllama
iamllama committed Apr 24, 2025
commit 38eda25887ff533af192387f32231fe72da93d7d
2 changes: 1 addition & 1 deletion rslib/src/search/sqlwriter.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -555,7 +555,7 @@ impl SqlWriter<'_> {
}

fn write_all_fields(&mut self, val: &str) {
self.args.push(format!("(?i)^{}$", to_re(val)));
self.args.push(format!("(?is)^{}$", to_re(val)));
write!(self.sql, "regexp_fields(?{}, n.flds)", self.args.len()).unwrap();
}

Expand Down