calculate accurate retrievability in card info by elapsed seconds #4034
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks Jarrett! |
Contributor
|
Do we really need a new function in FSRS-rs for this? Can't the same result be obtained by something like the following? let days_elapsed = self
.storage
.time_of_last_review(card.id)?
.map(|ts| timing.now.elapsed_secs_since(ts))
.unwrap_or_default() as u32 / 86400.0;
let fsrs_retrievability = card
.memory_state
.zip(Some(days_elapsed))
.zip(Some(card.decay.unwrap_or(FSRS5_DEFAULT_DECAY)))
.map(|((state, days), decay)| {
FSRS::new(None).unwrap().current_retrievability(
state.into(),
days,
decay,
)
}); |
Contributor
|
After open-spaced-repetition/fsrs-rs#333 by Luc, the code in FSRS-rs looks much cleaner. So, you can disregard my suggestion above as it's probably cleaner to create a new function for handling elapsed time in seconds if we are going to use it in multiple places. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
The new one is close to the R displayed in the forgetting curve: