Set Due Date: Set interval to actual elapsed days when FSRS is enabled #4035
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
user1823
reviewed
May 26, 2025
| } else { | ||
| self.interval | ||
| }; | ||
| let fsrs_enabled = self.memory_state.is_some(); |
Contributor
There was a problem hiding this comment.
Does this work if the card lacks memory states because it has been moved between decks?
Contributor
Author
There was a problem hiding this comment.
yes, but I have not other good solution to know whether this card is scheduled by FSRS without looking at the collection global setting.
Contributor
This will cause issues in cases where the |
Contributor
Author
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
modified from #3688, fix #3701
warning: it assumes the previous
dueandivlare correct.