Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@Luc-Mcgrady
Copy link
Contributor

@dae dae merged commit a99beb7 into ankitects:main Jun 2, 2025
1 check passed
@Luc-Mcgrady Luc-Mcgrady deleted the cid-field branch June 2, 2025 09:35
@bryanboateng
Copy link

Hey @Luc-Mcgrady, I have a question.
In the code base above the add_special_fields function there is a comment that states:

/// Add special fields if they don't clobber note fields.
/// The fields supported here must coincide with SPECIAL_FIELDS in
/// notetype/mod.rs, apart from FrontSide which is handled by Python.

To me that reads that any field added to the add_special_fields function also needs to be in SPECIAL_FIELDS.
You didn't add "CardID" to SPECIAL_FIELDS. Is that intentional? If so, why?

@Luc-Mcgrady
Copy link
Contributor Author

Well spotted! Seems like an oversight to me. I'll try and add a test for the future.

@bryanboateng
Copy link

I can also add it. Though writing the test will take me a bit longer than you.

@Luc-Mcgrady
Copy link
Contributor Author

Too late 😅

@bryanboateng
Copy link

No problem, thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants