Allow creating deck via #deck:... if non-existent when importing
#4154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dae
reviewed
Jul 4, 2025
Member
dae
left a comment
There was a problem hiding this comment.
Thank you as always! I'll circle back to this once things die down a bit with the new release. Just one minor point for now based on a quick skim:
proto/anki/import_export.proto
Outdated
| repeated generic.StringList preview = 14; | ||
| uint32 guid_column = 15; | ||
| DupeResolution dupe_resolution = 16; | ||
| MatchScope match_scope = 17; |
Member
There was a problem hiding this comment.
I'd recommend just using <next biggest number> for deck_name, so that the other fields don't need to be renumbered. Keeps the git blame tidy, and avoids a practice that would cause breakages if it was done on certain messages (think Notetypes that are persisted in the DB for example).
Member
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr proposes to allow creating the deck specified by
#deck:...if it didn't already exist when importing csv files, which brings it in line with#deck column:...'s behaviourref: https://forums.ankiweb.net/t/feature-request-creating-new-decks-from-import-text-file-screen/62288/14