Use system font for webviews instead of bootstrap font stack and add exception for note editor #4163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t stack …" This reverts commit d179355.
Member
|
I'd like to hold off on further changes here until the stable release has a chance to settle a bit - ideally we'll have another beta build soon that we can test this in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #4159
Fixes: #4158
My previous fix works for every view I tested, except for the note editor, which inherits Noto Sans on my machine (or the bs font stack, if all
font-familyare removed from the code).This PR adds back the fix to the webviews that work as expected, while adding an exception for the note editor. I couldn't figure out how to solve this, which is why I plan to open a new issue onces this PR is merged.