Statically link MSVC runtime, removing the need to install the redistributable #4166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
066660f to
1ea8eaf
Compare
1987c87 to
da5ee28
Compare
…t commit got mangled.
Contributor
Author
|
Sorry for the force spam. My email got mangled in #4162 by co-authorship. So my original commit passed, then a github domain ended in the authorship due to co-authorship. |
abdnh
approved these changes
Jul 5, 2025
Collaborator
abdnh
left a comment
There was a problem hiding this comment.
Working nicely on Windows Sandbox.
Member
|
Thank you for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://forums.ankiweb.net/t/windows-error-vcruntime140-dll-not-found-when-installing-with-the-launcher-possible-fix/63508.
before and after for the launcher exe.
Anki running on LTSC19 with nothing installed and no updates.
I don't have a convenient development setup with ninja, so didn't test full packaging; only launcher and anki-console from cargo. Binary size will increase by about 100kB or so.