-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Fix/Help modal appears behind simulator modal #4171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Possible alternative to avoid setting z-index, but the backdrop gets left behind diff --git a/ts/lib/components/TitledContainer.svelte b/ts/lib/components/TitledContainer.svelte
index 70e4a078c..a2f116427 100644
--- a/ts/lib/components/TitledContainer.svelte
+++ b/ts/lib/components/TitledContainer.svelte
@@ -41,11 +41,11 @@ License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html
{title}
</h1>
{/if}
- <div class="help-badge position-absolute" class:rtl>
- <slot name="tooltip" />
- </div>
</div>
<slot />
+ <div class="help-badge position-absolute" class:rtl>
+ <slot name="tooltip" />
+ </div>
</div>
<style lang="scss">
|
|
The opened modal doesn't correspond to the simulator options, e.g. clicking on any simulator option opens up the modal at the last-opened section, so perhaps that should be changed here as well if its to be visible |
It seems like to get this to work properly we'd need to do some crazy stuff with the "settings" because the settings here are all it has access to. anki/ts/routes/deck-options/FsrsOptionsOuter.svelte Lines 33 to 78 in 4232185
so I'll just leave it as is for now. Maybe it would just be best to give up on the help modal for the simulator modal entirely? |
|
An alternative could be creating a help modal solely for the simulator menu that copies the entries from the respective already existing modals? |
|
While this is still being discussed, I'll merge in what we currently have, as it's still an improvement over what we had previously. |
I think this comes with the caveat of making the background of the help modal everywhere else 75% opaque (as there will be 2 layers), but its quite un-noticeable.