Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@Grinkers
Copy link
Contributor

@Grinkers Grinkers commented Jul 8, 2025

See #4177. A better ordering.

Kitty is default in a lot of various Wayland DE's, so it's after Alacritty. I'm not sure where foot really fits in.

@Grinkers
Copy link
Contributor Author

Grinkers commented Jul 8, 2025

@pkubowicz Does this seem better?

@Grinkers Grinkers force-pushed the terminal-reorder branch from 66bd5f2 to 173154c Compare July 8, 2025 05:36
@dae
Copy link
Member

dae commented Jul 8, 2025

On Debian/Ubuntu, x-terminal-emulator should be a symlink to the user's preferred terminal program, so it might be worth putting up higher? Not sure how many users have it accurately set though.

@Grinkers
Copy link
Contributor Author

Grinkers commented Jul 8, 2025

On Debian/Ubuntu, x-terminal-emulator should be a symlink to the user's preferred terminal program, so it might be worth putting up higher? Not sure how many users have it accurately set though.

I don't have a convenient debian based system to check, but if setting x-terminal-emulator is opt-in then it should certainly be higher. I guess if we're being more complete, we should probably look for $XDG_CURRENT_DESKTOP so even if a user has both kde and gnome, we pick the right one. Not sure if this is all worth it, instead of just working on the gui though.

At the very least, I do think this ordering is better. Essentially riced -> wayland -> x11

@Grinkers Grinkers force-pushed the terminal-reorder branch from 173154c to 1bf6223 Compare July 8, 2025 06:13
@pkubowicz
Copy link
Contributor

Thank you for doing the tweaks.

In my Kubuntu, I have x-terminal-emulator installed by default and running it starts Konsole.

But the order looks good enough now.

@dae
Copy link
Member

dae commented Jul 8, 2025

Fingers crossed this doesn't cause another regression!

@dae dae merged commit 6744a0a into ankitects:main Jul 8, 2025
1 check was pending
@GithubAnon0000
Copy link
Contributor

On Debian/Ubuntu, x-terminal-emulator should be a symlink to the user's preferred terminal program

I can confirm this is true (tested on debian).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants