Add margin to QPushButton to prevent clipping #4201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abdnh
approved these changes
Jul 13, 2025
Contributor
|
@jcznk, thank you for the fix. I think that this change has largely fixed the issue. But, I still noticed some clipping. In the choose deck window opened from the Add note window in Anki 25.09, On hover: (The screenshot tool didn't capture the mouse pointer) It would be great if you could fix this too. |
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4183
Took inspiration from: https://stackoverflow.com/questions/66637388/is-there-a-way-to-change-the-external-border-of-a-qpushbutton
This trick should prevent border growth on QPushButtons on
focusandhoverfrom shrinking the space available for the button’s label. Previously, this could cause text (such asYesin confirmation dialogs) to be clipped on the left and right.Before:
After:
