Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix/use real step count to simulate #4240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dae merged 2 commits into from
Aug 4, 2025
Merged

Fix/use real step count to simulate #4240

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fcb0603
Fix/use real step count to simulate
L-M-Sherlock Aug 3, 2025
8c27dcc
Update licenses.json
L-M-Sherlock Aug 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 23 additions & 23 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ git = "https://github.com/ankitects/linkcheck.git"
rev = "184b2ca50ed39ca43da13f0b830a463861adb9ca"

[workspace.dependencies.fsrs]
version = "5.0.0"
version = "5.0.1"
# git = "https://github.com/open-spaced-repetition/fsrs-rs.git"
# branch = "Refactor/expected_workload_via_dp"
# rev = "a7f7efc10f0a26b14ee348cc7402155685f2a24f"
Expand Down
6 changes: 3 additions & 3 deletions cargo/licenses.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1450,7 +1450,7 @@
},
{
"name": "fsrs",
"version": "5.0.0",
"version": "5.0.1",
"authors": "Open Spaced Repetition",
"repository": "https://github.com/open-spaced-repetition/fsrs-rs",
"license": "BSD-3-Clause",
Expand Down Expand Up @@ -3322,7 +3322,7 @@
},
{
"name": "rand",
"version": "0.9.1",
"version": "0.9.2",
"authors": "The Rand Project Developers|The Rust Project Developers",
"repository": "https://github.com/rust-random/rand",
"license": "Apache-2.0 OR MIT",
Expand Down Expand Up @@ -4132,7 +4132,7 @@
},
{
"name": "strum",
"version": "0.27.1",
"version": "0.27.2",
"authors": "Peter Glotfelty <[email protected]>",
"repository": "https://github.com/Peternator7/strum",
"license": "MIT",
Expand Down
2 changes: 2 additions & 0 deletions proto/anki/scheduler.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,6 +407,8 @@ message SimulateFsrsReviewRequest {
deck_config.DeckConfig.Config.ReviewCardOrder review_order = 11;
optional uint32 suspend_after_lapse_count = 12;
float historical_retention = 13;
uint32 learning_step_count = 14;
uint32 relearning_step_count = 15;
}

message SimulateFsrsReviewResponse {
Expand Down
4 changes: 2 additions & 2 deletions rslib/src/scheduler/fsrs/simulator.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,8 +237,8 @@ impl Collection {
learning_step_transitions: p.learning_step_transitions,
relearning_step_transitions: p.relearning_step_transitions,
state_rating_costs: p.state_rating_costs,
learning_step_count: p.learning_step_count,
relearning_step_count: p.relearning_step_count,
learning_step_count: req.learning_step_count as usize,
relearning_step_count: req.relearning_step_count as usize,
};

Ok((config, converted_cards))
Expand Down
2 changes: 2 additions & 0 deletions ts/routes/deck-options/FsrsOptions.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,8 @@ License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html
easyDaysPercentages: $config.easyDaysPercentages,
reviewOrder: $config.reviewOrder,
historicalRetention: $config.historicalRetention,
learningStepCount: $config.learnSteps.length,
relearningStepCount: $config.relearnSteps.length,
});

const DESIRED_RETENTION_LOW_THRESHOLD = 0.8;
Expand Down