Fix/Invalid memory states in simulator after parameters changed #4317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
user1823
suggested changes
Sep 3, 2025
| # cards that can be recalled or retrieved on a specific date. | ||
| deck-config-fsrs-simulator-experimental = FSRS Simulator (Experimental) | ||
| deck-config-fsrs-simulate-desired-retention-experimental = FSRS Desired Retention Simulator (Experimental) | ||
| deck-config-fsrs-simulate-save-preset = After optimizing, please save your config before running the simulator. |
Contributor
There was a problem hiding this comment.
Suggested change
| deck-config-fsrs-simulate-save-preset = After optimizing, please save your config before running the simulator. | |
| deck-config-fsrs-simulate-save-preset = Please save the updated parameters before running the simulator. |
Contributor
Author
There was a problem hiding this comment.
I think its better if we keep the focus on saving the config, as there is no way to save the parameters separately.
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4064
This will prevent users from running the simulator after optimizing, before saving the preset.