Updated Dockerfile to use Ninja build system #4321
Merged
+64
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abdnh
reviewed
Sep 15, 2025
Contributor
Author
|
Hey @abdnh thanks for the input, missed that! 😀 I have updated the python version now, builds as expected. |
Member
|
Thank you both! |
AmandaSternberg-creator
pushed a commit
to AmandaSternberg-creator/anki
that referenced
this pull request
Sep 25, 2025
* Updated Dockerfile to support ninja build * Install python using uv * Bumped python version * Add disclaimer (dae)
MarkMoretto
reviewed
Dec 31, 2025
|
|
||
| # Install pre-compiled Anki. | ||
| FROM python:${PYTHON_VERSION}-slim as installer | ||
| FROM python:3.13-slim AS installer |
There was a problem hiding this comment.
I'd be interested to know more about hardcoding the vesion here vs. using the PYTHON_VERSION environment variable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! First PR so hope I get this right.
Changes
Updated the old Dockerfile that used Blaze build, to using Ninja.
Wheels are not included in the final image to make it as small as possible.