Make timebox message translatable with flexible variable order #4338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1656b1d to
1f43edf
Compare
38df4e3 to
d2a80ec
Compare
Currently, the timebox dialog message is built from two separate strings,
each containing one variable:
"{ $count } cards studied in" + "{ $count } minutes."
As a result, translators cannot freely reorder the variables in their translations.
This change introduces a single string with both variables, allowing translators
to adjust the order for more natural expressions in their languages.
d2a80ec to
6a1e521
Compare
Member
|
Thanks! |
Contributor
|
It's a small change, but one that makes translators' lives a lot easier. Word puzzles composed of two or more strings that combine into a single final message are extremely difficult to translate. Unfortunately, Anki contains many of them. I would love to see them eliminated. @snowtimeglass Thanks so much for your work and this pull request! |
Contributor
Author
|
@sommerluk Thanks a lot for your encouraging words! |
AmandaSternberg-creator
pushed a commit
to AmandaSternberg-creator/anki
that referenced
this pull request
Sep 25, 2025
…ects#4338) * Make timebox message translatable with flexible variable order Currently, the timebox dialog message is built from two separate strings, each containing one variable: "{ $count } cards studied in" + "{ $count } minutes." As a result, translators cannot freely reorder the variables in their translations. This change introduces a single string with both variables, allowing translators to adjust the order for more natural expressions in their languages. * Preserve old string for now * Ensure message doesn't display over two lines --------- Co-authored-by: Damien Elmes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An example of the timebox message:
Currently, the timebox dialog message is built from two separate strings (and a space), each containing one variable:
{ $count } cards studied in+{ $count } minutes.As a result, translators cannot flexibly reorder the variables in their translation.
(In contrast, they can do so for
Studied x cards in y minutes today (z s/card)on the deck list and the statistics screen.)This PR's commit introduces a single string with both variables for the timebox message, allowing translators to adjust the order for more natural expressions in their languages.