feat: show saved custom colours as options in fill tool colour picker on mobile #4348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is primarily for mobile clients, as qt currently ignores this
abdnh
approved these changes
Sep 25, 2025
AmandaSternberg-creator
pushed a commit
to AmandaSternberg-creator/anki
that referenced
this pull request
Sep 25, 2025
… on mobile (ankitects#4348) * add GetCustomColours rpc method * save colours as rgb instead of argb * show saved custom colours as possible options in colour picker this is primarily for mobile clients, as qt currently ignores this * save custom colours on colour picker change (for desktop)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a followup to #4326 (comment), this pr proposes to show the saved custom colours as preset options in the io fill tool's colour picker on mobile clients:
I've added a new rpc method (replaceable by
getConfigJsonthat Abdo's editor pr will introduce), and changed the saved format from argb to rgb for use in the web (existing saved colours will be silently converted)