-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Add "each from random deck" gather priority #4352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
f8add6c to
f2923b9
Compare
jariji
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Responded to comments.
|
This is looking good to me, but please wait for dae to give it a look too. |
|
Hi, sorry for asking here, but does your implementation consider all nested decks when choosing the random deck? If that's the case, then it might make the randomness biased towards decks with many many subdecks. It would also break the order criterion. For example if we have: with cards in What I had in mind and probably others too, was that it would simply pick a random direct subdeck of the deck we click on to study and "flattening" all the nested subdecks (treat all the cards in the subdecks of a direct subdeck as if they were in the direct subdeck). [I originally didn't consider the deck itself.] With the example above, when clicking on Edit: (unrelated to my points above) a possible improvement is to weight the subdecks by the number of new cards available to study, so that we don't end up with many cards from a subdeck which has a larger new card limit. |
|
This PR picks a random descendant deck rather than a random child deck. I think you may be right, for unbalanced trees it could be better to distribute among the children (and self) rather than all the descendants (and self). |
The forums had a discussion about gathering cards from random decks. This PR implements that feature.
For each new card to be gathered, a random deck is chosen, and the next card is taken from that deck, respecting deck and parent and root limits.