-
Notifications
You must be signed in to change notification settings - Fork 2.7k
feat: launcher gui #4390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: launcher gui #4390
Conversation
|
This is impressive work llama! I'll need a bit more time to review the current code properly, but I wanted to give you some quick feedback to unblock you.
thread 'tokio-runtime-worker' panicked at qt/launcher-gui/src-tauri/src/commands.rs:140:58: The existing code expects the launcher binary to be run from within an app bundle. This is how the layout looks like for the terminal version: build.sh in qt/launcher/mac takes care of the building that folder after compiling. If you don't have access to a Mac, I can take care of this before the alpha test. Should hopefully have more comments in the next few days! |
to make alert() work
xterm.js' new DOM renderer seems to have some visual glitches, try using the webgl renderer first before falling back
this broke somewhere down the line and needs a tick now
|
I probably won't have a chance to circle back to this until late this week/early next week :-( If you're blocked on anything, please let me know and I'll try to get to that earlier. |
c24a17d to
1622f9b
Compare
To run, install tauri's system dependencies, cli (cargo) and then, in the repo root,
cargo tauri devwith.\yarn ldin another windowTentatively based it on the options pages (i probably won't be of much help here)
Closes #4152
EDIT: CI is missing some of tauri's needed system deps