Start decoding images immediately #4471
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Is this the same as decoding the images synchronously? Would if (!img.getAttribute("decoding")) {
img.decoding = "sync";
}give the same result? Here is the relevant issue and pull request: It is possible you would be interested in the upcoming reviewer in #4289 as this pre-loads the images of the next card, although this will not help for the first card. |
Contributor
Author
|
Whoops, you're right. I've fixed it. This change actually causes the backside images to be decoded while on the front of the card. To demonstrate, here's a test card loading an 8000x8000 image. Old behavior: New behavior: |
Luc-Mcgrady
approved these changes
Dec 19, 2025
Contributor
Luc-Mcgrady
left a comment
There was a problem hiding this comment.
Cool! Be sure to add yourself to the CONTRIBUTORS file so the CLI can pass.
Collaborator
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a recent commit, images are set to decode asynchronously. However, decoding is not initiated until the image is displayed. This small change allows images to begin decoding immediately, which greatly speeds up loading times (especially on the answer side) of cards with a lot of images (AnKing).